fix: Don't check for matching sync/async function type #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
changed the title
Merged
jsumners-nr
requested changes
Jun 4, 2025
jsumners-nr
approved these changes
Jun 4, 2025
Contributor
jsumners-nr
left a comment
jsumners-nr
left a comment
There was a problem hiding this comment.
(stamp) Looks good to me.
Contributor
|
code and test updates look good, I'm just going to double check with my work I've been doing |
bizob2828
approved these changes
Jun 4, 2025
Contributor
bizob2828
left a comment
bizob2828
left a comment
There was a problem hiding this comment.
this update works with the use case I originally reported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @bizob2828,
The AST walker was only instrumenting a function when the sync/async matched the instrumentation. However, this stopped non-async functions that return a promise from being instrumented with
tracePromise:Since you can't have multiple functions with the same name, this check is not required.